In the function rtl8188eu_hal_init() else after the return statement of the if section is not useful. As if condition is true function will return from if section, On the other case if condition is false function will not return and statement after the if section will execute, So there is no need to have else in this case. Remove the else after a return statement of the if section. Signed-off-by: Saurav Girepunje <saurav.girepunje@xxxxxxxxx> --- drivers/staging/r8188eu/hal/usb_halinit.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/staging/r8188eu/hal/usb_halinit.c b/drivers/staging/r8188eu/hal/usb_halinit.c index 94a2b3e32fe7..bea5d147b2a1 100644 --- a/drivers/staging/r8188eu/hal/usb_halinit.c +++ b/drivers/staging/r8188eu/hal/usb_halinit.c @@ -687,10 +687,11 @@ u32 rtl8188eu_hal_init(struct adapter *Adapter) Adapter->bFWReady = false; haldata->fw_ractrl = false; return status; - } else { - Adapter->bFWReady = true; - haldata->fw_ractrl = false; } + + Adapter->bFWReady = true; + haldata->fw_ractrl = false; + rtl8188e_InitializeFirmwareVars(Adapter); HAL_INIT_PROFILE_TAG(HAL_INIT_STAGES_MAC); -- 2.33.0