Re: [PATCH] staging: wlan-ng: Fix formatting of block comments

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Oct 30, 2021 at 12:08:25PM +0200, Gabriel Goller wrote:
> Fixed warnings of checkpatch.pl in prism2mib.c:
> Block comments use * on subsequent lines.
> 
> Signed-off-by: Gabriel Goller <gabrielgoller123@xxxxxxxxx>
> ---
>  drivers/staging/wlan-ng/prism2mib.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/staging/wlan-ng/prism2mib.c b/drivers/staging/wlan-ng/prism2mib.c
> index 24ba10d6bd0b..c04fc17b3c64 100644
> --- a/drivers/staging/wlan-ng/prism2mib.c
> +++ b/drivers/staging/wlan-ng/prism2mib.c
> @@ -680,15 +680,15 @@ static int prism2mib_priv(struct mibrec *mib,
>  					       (u8 *)&wpa,
>  					       sizeof(wpa));
>  			/*
> -			pstr->len = le16_to_cpu(wpa.datalen);
> -			memcpy(pstr->data, wpa.data, pstr->len);
> -			*/
> +			 * pstr->len = le16_to_cpu(wpa.datalen);
> +			 * memcpy(pstr->data, wpa.data, pstr->len);
> +			 */

Why keep this code at all?  Please just delete it as it's obviously not
being used.

thanks,

greg k-h




[Index of Archives]     [Linux Driver Development]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux