On Thursday, October 28, 2021 4:35:30 PM CEST Karolina Drobnik wrote: > On Thu, 2021-10-28 at 14:36 +0200, Fabio M. De Francesco wrote: > > As far as I know by reading some Greg K-H's replies to other > > developers, this > > "<test> ? <true> : <false>" style is not well accepted here. > > I thought that the expression is simple enough that it can be written > this way. Julia nicely summarised why I think it's a good usage of the > conditional operator. Still, there's no problem in changing it to "if- > else" statement if that's the preferred option. If I were you, I'd leave the patch as-is and wait for Greg review. I was only reporting some words that I recall I read in some emails of Greg. But it is highly probable that those contexts were a bit different or that the statements were much more complex. As far as what my personal preference is, I think that you shouldn't care because I'm not one of the maintainers. Above all, even if I were one of the maintainers I'd never prevent developers to use their own style with this kind of statements. To summarize, you'd better leave the patch as-is. Thanks, Fabio > > Thanks, > Karolina > > > >
