Hi Alison, On Fri, 2021-10-22 at 09:40 -0700, Alison Schofield wrote: > On Fri, Oct 22, 2021 at 10:37:15AM +0100, Karolina Drobnik wrote: > > Drop Hungarian notation in `byInitCount` variable in > > `RFvWriteWakeProgSyn` function. Change it to use snake case. > > > > Fix issue detected by checkpatch.pl: > > CHECK: Avoid CamelCase: <byInitCount> > > Hi Karolina, > > This comment is for all the patches. > > Commit msg: > We've got plenty of space on that line, how about: > "Rename byInitCount init_count" > > (I say this because when someone searches by the oneliners it's > nice to give as many keywords as possible - within the line limit) Ok, will do my best to include it in my upcoming patchset. > Commit log: > The log (why this patch is important) seems to be saying that > snake case is the fix for Hungarian notation. I don't think that > is completely true. Snake case avoids the camel case of Hungarian > notation, but we are also dropping the type descriptor which is > another signature of Hungarian notation. > > Perhaps this would be more direct: > > To align with the kernel coding style, remove the type from > the variable name and do not use CamelCase. Ok, I'll use this format from now on. Thanks, Karolina
