Re: [PATCH v2 4/8] staging: vchiq_core.h: use preferred kernel types

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Oct 24, 2021 at 06:25:20PM -0300, Gaston Gonzalez wrote:
> Change types from uint32_t and uint64_t to the preferred ones u32 and
> u64.
> 
> Reported by checkpatch.pl, with the exception of the one in function
> vchiq_log_dump_mem().
> 
> Signed-off-by: Gaston Gonzalez <gascoar@xxxxxxxxx>
> ---
>  .../vc04_services/interface/vchiq_arm/vchiq_core.h   | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h
> index 383c3bcf787e..a107c72ce3a6 100644
> --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h
> +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h
> @@ -74,7 +74,7 @@
>  	((fourcc) >>  8) & 0xff, \
>  	(fourcc) & 0xff
>  
> -typedef uint32_t BITSET_T;
> +typedef u32 BITSET_T;

This is fine for now, but you should also work to get rid of this
unneeded typedef entirely.

thanks,

greg k-h




[Index of Archives]     [Linux Driver Development]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux