On Wed, Oct 20, 2021 at 09:53:57PM +0200, Martin Kaiser wrote:
> Remove unused components from struct dm_priv.
>
> DMFlag is only written to, but never read.
> InitDMFlag is assigned to DMFlag and not used elsewhere.
> DM_Type is also write-only.
> UndecoratedSmoothedPWDB and UndecoratedSmoothedCCK are not used at all.
>
> Signed-off-by: Martin Kaiser <martin@xxxxxxxxx>
> ---
> drivers/staging/r8188eu/hal/rtl8188e_dm.c | 3 ---
> drivers/staging/r8188eu/hal/usb_halinit.c | 1 -
> drivers/staging/r8188eu/include/rtl8188e_dm.h | 5 -----
> 3 files changed, 9 deletions(-)
>
> diff --git a/drivers/staging/r8188eu/hal/rtl8188e_dm.c b/drivers/staging/r8188eu/hal/rtl8188e_dm.c
> index 4ce2c3749665..5d76f6ea91c4 100644
> --- a/drivers/staging/r8188eu/hal/rtl8188e_dm.c
> +++ b/drivers/staging/r8188eu/hal/rtl8188e_dm.c
> @@ -87,12 +87,9 @@ static void Update_ODM_ComInfo_88E(struct adapter *Adapter)
> void rtl8188e_InitHalDm(struct adapter *Adapter)
> {
> struct hal_data_8188e *hal_data = GET_HAL_DATA(Adapter);
> - struct dm_priv *pdmpriv = &hal_data->dmpriv;
> struct odm_dm_struct *dm_odm = &hal_data->odmpriv;
>
> dm_InitGPIOSetting(Adapter);
> - pdmpriv->DM_Type = DM_Type_ByDriver;
> - pdmpriv->DMFlag = DYNAMIC_FUNC_DISABLE;
> Update_ODM_ComInfo_88E(Adapter);
> ODM_DMInit(dm_odm);
> Adapter->fix_rate = 0xFF;
> diff --git a/drivers/staging/r8188eu/hal/usb_halinit.c b/drivers/staging/r8188eu/hal/usb_halinit.c
> index cdc602fa9af8..ef1ae95d7db0 100644
> --- a/drivers/staging/r8188eu/hal/usb_halinit.c
> +++ b/drivers/staging/r8188eu/hal/usb_halinit.c
> @@ -1469,7 +1469,6 @@ void SetHwReg8188EU(struct adapter *Adapter, u8 variable, u8 *val)
> break;
> case HW_VAR_DM_FUNC_SET:
> if (*((u32 *)val) == DYNAMIC_ALL_FUNC_ENABLE) {
> - pdmpriv->DMFlag = pdmpriv->InitDMFlag;
> podmpriv->SupportAbility = pdmpriv->InitODMFlag;
> } else {
> podmpriv->SupportAbility |= *((u32 *)val);
> diff --git a/drivers/staging/r8188eu/include/rtl8188e_dm.h b/drivers/staging/r8188eu/include/rtl8188e_dm.h
> index 4a0608313f7a..208bea050f6f 100644
> --- a/drivers/staging/r8188eu/include/rtl8188e_dm.h
> +++ b/drivers/staging/r8188eu/include/rtl8188e_dm.h
> @@ -15,14 +15,9 @@ enum{
> #define HP_THERMAL_NUM 8
> /* duplicate code,will move to ODM ######### */
> struct dm_priv {
> - u8 DM_Type;
> - u8 DMFlag;
> - u8 InitDMFlag;
> u32 InitODMFlag;
>
> /* Upper and Lower Signal threshold for Rate Adaptive*/
> - int UndecoratedSmoothedPWDB;
> - int UndecoratedSmoothedCCK;
> int EntryMinUndecoratedSmoothedPWDB;
> int EntryMaxUndecoratedSmoothedPWDB;
> int MinUndecoratedPWDBForDM;
> --
> 2.20.1
>
Looks good.
Acked-by: Phillip Potter <phil@xxxxxxxxxxxxxxxx>
Regards,
Phil
