On Wed, 2021-10-20 at 07:09 -0700, Joe Perches wrote: > On Wed, 2021-10-20 at 06:44 -0700, Joe Perches wrote: > > In this file there are more than 100 uses of > > > > (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW > > > > Maybe add a define for it and substitute the uses for the define. > > Look at the code too. > > It looks as if every use of IFRFbWriteEmbedded() has this added to > the 2nd argument and that the 2nd argument isn't used anywhere else. > > Maybe remove it altogether and add it to IFRFbWriteEmbedded(). > > And it looks as if the + uses for these should logically be | Sounds like a very good idea. I'll add it to my to-do list, thanks :) On Wed, 2021-10-20 at 16:16 +0200, Julia Lawall wrote: > Karolina, > > If more than a hundred such changes are necessary, you may find > Coccinelle > useful: https://coccinelle.gitlabpages.inria.fr/website/ Hmm, I'll check this out, it may come in handy. Thanks, Karolina
