On Tuesday, October 19, 2021 2:26:05 PM CEST Joe Perches wrote: > On Tue, 2021-10-19 at 11:59 +0100, Karolina Drobnik wrote: > > Hi, > > > > Thank you very much for your comments. > > > > On Mon, 2021-10-18 at 17:12 +0200, Greg KH wrote: > > > Also, these are all just fine as-is for now. A better way to make > > > these lines smaller is to use better variable and function names > > > that are shorter and make sense :) > > > > I have v2 ready but I'm not sure, given the Joe's patch, if my solution > > is a satisfactory one. I didn't jump on such refactoring as I'm still > > learning about the codebase/process and didn't want to muddle the > > waters (...more than I do already). > > > > Greg, what would you prefer? Should I back up with my patch, pick > > something else and let Joe's patch be merged? > > What I suggested is not a patch it's just an example. Sorry, Joe. I sent a message trying to explain what you were showing to Karolina with your previous email. Soon after sending my reply, I noticed that you had already elaborated a bit more. I hope that you don't mind. If I wrote something that contradicts your thoughts and intentions please accept my apologies. Regards, Fabio
