On Monday, October 18, 2021 4:42:51 PM CEST Greg Kroah-Hartman wrote:
> On Sun, Oct 17, 2021 at 04:28:12PM +0200, Fabio M. De Francesco wrote:
> > Remove a redundant 'if' statement.
> >
> > Acked-by: Martin Kaiser <martin@xxxxxxxxx>
> > Acked-by: Phillip Potter <phil@xxxxxxxxxxxxxxxx>
> > Signed-off-by: Fabio M. De Francesco <fmdefrancesco@xxxxxxxxx>
> > ---
> > drivers/staging/r8188eu/core/rtw_cmd.c | 6 ------
> > 1 file changed, 6 deletions(-)
>
> Why is there not a "v2" in the subject line like the other patches in
> this series?
Simply because I edited manually the "Subject" and overlooked to write "v2".
>
> >
> > diff --git a/drivers/staging/r8188eu/core/rtw_cmd.c b/drivers/staging/
r8188eu/core/rtw_cmd.c
> > index 6fb79d711692..42084b029473 100644
> > --- a/drivers/staging/r8188eu/core/rtw_cmd.c
> > +++ b/drivers/staging/r8188eu/core/rtw_cmd.c
> > @@ -254,12 +254,6 @@ int rtw_cmd_thread(void *context)
> > while (1) {
> > wait_for_completion(&pcmdpriv->enqueue_cmd);
> >
> > - if (padapter->bDriverStopped ||
> > - padapter->bSurpriseRemoved) {
> > - DBG_88E("%s: DriverStopped(%d)
SurpriseRemoved(%d) break at line %d\n",
> > - __func__, padapter-
>bDriverStopped, padapter->bSurpriseRemoved, __LINE__);
> > - break;
> > - }
>
>
> Why is this redundant?
>
> It is not obvious from the diff what is going on so you should say a bit
> more in the changelog text please.
Yes you are right. I wrongly thought that is was "obvious", but re-reading my
own text I noticed that it is not.
In 1/3 and 2/3 I was particularly careful in writing changelogs. Instead in
3/3 I forgot that commit messages _must_ explain "what" and "why" :(
I've just sent version 3 of the series.
Thanks for reviewing my work,
Fabio
>
> thanks,
>
> greg k-h
>
