This is almost a BUG report with a patch to just make atomisp work
again with the current mainline kernel. Thus, prefixed with [BUG][RFC].
RFC:
1. When looking at the `case CI_MODE_NONE:`, it tries to do something.
So, it should rather work with CI_MODE_NONE, too? Just I don't know
how to configure userspace apps to use CI_MODE_NONE ?
2. How can we re-add the run mode support again without relying on
the s_parm ?
>8-----------------------------------------------------------------8<
After the commit 8a7c5594c020 ("media: v4l2-ioctl: clear fields in s_parm")
added on v4.18 (backported to v4.9.182 and v4.14.127), the capture mode
flag is cleared (except for V4L2_MODE_HIGHQUALITY).
Due to this, it seems that now we can't use this flag to set atomisp
run_mode. This results in capture not working with the following message
(loaded atomisp driver with dbg_level=1):
kern :warn : [ 3658.776616] ia_css_pipe_get_info: ia_css_stream_create needs to be called before ia_css_[stream/pipe]_get_info
kern :err : [ 3658.776641] atomisp-isp2 0000:00:03.0: get_frame_info 1920x1080 (padded to 0)
kern :warn : [ 3658.776666] atomisp-isp2 0000:00:03.0: Can't set format on ISP. Error -22
So, when we can't detect run mode from the s_parm capturemode
(CI_MODE_NONE), let's assume the run mode is PREVIEW.
Signed-off-by: Tsuchiya Yuto <kitakar@xxxxxxxxx>
---
drivers/staging/media/atomisp/pci/atomisp_ioctl.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/media/atomisp/pci/atomisp_ioctl.c b/drivers/staging/media/atomisp/pci/atomisp_ioctl.c
index c8a625667e81..6fc64f0ccc31 100644
--- a/drivers/staging/media/atomisp/pci/atomisp_ioctl.c
+++ b/drivers/staging/media/atomisp/pci/atomisp_ioctl.c
@@ -2638,7 +2638,11 @@ static int atomisp_s_parm(struct file *file, void *fh,
asd->high_speed_mode = true;
}
- goto out;
+ dev_warn(isp->dev,
+ "setting run_mode using s_parm capturemode is not supported anymore\n");
+ dev_warn(isp->dev, "assuming run_mode is PREVIEW\n");
+ mode = ATOMISP_RUN_MODE_PREVIEW;
+ break;
}
case CI_MODE_VIDEO:
mode = ATOMISP_RUN_MODE_VIDEO;
--
2.33.1
