Re: [PATCH 1/7] staging: r8188eu: remove empty functions from odm.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/16/21 11:29, Martin Kaiser wrote:
Thus wrote Michael Straube (straube.linux@xxxxxxxxx):

Remove empty functions from odm.c.

Signed-off-by: Michael Straube <straube.linux@xxxxxxxxx>
---
  drivers/staging/r8188eu/hal/odm.c             | 32 -------------------
  drivers/staging/r8188eu/hal/odm_HWConfig.c    |  7 +---
  drivers/staging/r8188eu/include/odm.h         |  7 ----
  drivers/staging/r8188eu/include/odm_precomp.h |  2 --
  4 files changed, 1 insertion(+), 47 deletions(-)

diff --git a/drivers/staging/r8188eu/hal/odm.c b/drivers/staging/r8188eu/hal/odm.c
index 2178ffe41bb3..627213392795 100644
--- a/drivers/staging/r8188eu/hal/odm.c
+++ b/drivers/staging/r8188eu/hal/odm.c
@@ -196,13 +196,9 @@ void ODM_DMWatchdog(struct odm_dm_struct *pDM_Odm)
  	    (pDM_Odm->AntDivType == CGCS_RX_HW_ANTDIV)	||
  	    (pDM_Odm->AntDivType == CG_TRX_SMART_ANTDIV))
  		odm_HwAntDiv(pDM_Odm);
-	else if (pDM_Odm->AntDivType == CGCS_RX_SW_ANTDIV)
-		odm_SwAntDivChkAntSwitch(pDM_Odm, SWAW_STEP_PEAK);

This was the last user of SWAW_STEP_PEAK. The define can be removed now
(maybe in a follow-up patch).

Acked-by: Martin Kaiser <martin@xxxxxxxxx>


Thank you for your review Martin. I'll send follow up patches to remove
this and other now unused variables I missed.

Thanks again,
Michael




[Index of Archives]     [Linux Driver Development]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux