On Sat, Oct 16, 2021 at 08:43:32AM +0200, Fabio M. De Francesco wrote: > 2) The second semaphore came to my attention while working on the first and > trying to understand what rtw_cmd_thread() is meant for. It is there for very > different reasons. There is only one relation between them, that is that they > are used into the same function. Nothing else. > > So I prefer to write a second commit message (in patch 2/3) that explains > what the semaphore does and why it is better to replace it with a condition > variable. Obviously, this "why are you changing it?" has a different answer > with respect of what I say in patch 1/3. > I don't think you're correct, but I will wait for you patch and look again. regards, dan carpenter