On Fri, Oct 15, 2021 at 11:24:44AM +0100, Karolina Drobnik wrote:
> Drop Hungarian notation prefix in `byPreambleType` member of
> struct vnt_private. Change it to use snake case. Update
> comment for `bb_get_frame_time` to reflect that change.
>
> Fix issue detected by checkpatch.pl:
> CHECK: Avoid CamelCase: <byPreambleType>
>
> Signed-off-by: Karolina Drobnik <karolinadrobnik@xxxxxxxxx>
> ---
> drivers/staging/vt6655/baseband.c | 8 ++---
> drivers/staging/vt6655/baseband.h | 2 +-
> drivers/staging/vt6655/device.h | 2 +-
> drivers/staging/vt6655/device_main.c | 8 ++---
> drivers/staging/vt6655/rxtx.c | 50 ++++++++++++++--------------
> 5 files changed, 35 insertions(+), 35 deletions(-)
>
> diff --git a/drivers/staging/vt6655/baseband.c b/drivers/staging/vt6655/baseband.c
> index 0bae35af6e0f..7a5f186f2598 100644
> --- a/drivers/staging/vt6655/baseband.c
> +++ b/drivers/staging/vt6655/baseband.c
> @@ -1691,7 +1691,7 @@ static const unsigned short awc_frame_time[MAX_RATE] = {
> *
> * Parameters:
> * In:
> - * by_preamble_type - Preamble Type
> + * preamble_type - Preamble Type
This is not part of a structure.
> * by_pkt_type - PK_TYPE_11A, PK_TYPE_11B, PK_TYPE_11GB, PK_TYPE_11GA
> * cb_frame_length - Baseband Type
> * tx_rate - Tx Rate
> @@ -1700,7 +1700,7 @@ static const unsigned short awc_frame_time[MAX_RATE] = {
> * Return Value: FrameTime
> *
> */
> -unsigned int bb_get_frame_time(unsigned char by_preamble_type,
> +unsigned int bb_get_frame_time(unsigned char preamble_type,
Neither is this :(
Do not do multiple different things in the same commit and especially
when you do not describe them in the changelog text.
thanks,
greg k-h
