On Thursday, October 14, 2021 4:40:00 PM CEST Saurav Girepunje wrote: > Remove goto statement where function simply return value without doing > any cleanup action. > > Simplify the return using goto label to avoid unneeded 'if' condition > check. > > Remove the unneeded and redundant check of variable on goto. > > Remove the assignment of NULL on local variable. > > Signed-off-by: Saurav Girepunje <saurav.girepunje@xxxxxxxxx> > --- > > ChangeLog V3: > > -Remove goto statement where function simply return value > without doing any cleanup action. > -Remove the assignment of NULL on local variable. > -Replace the goto statement added after the memcpy on V2. > with return 0 statement. > > ChangeLog V2: > > -Add goto out after the memcpy for no error case return with > ret only. On V1 doing free, which was not required for no error > case. You still don't explain why you changed v1. You had freed resources on success path. That was not allowed because you introduced a change in the logic and a huge bug. Therefore, in v2, you are not merely changing something that "was not required". Instead you are changing something that is not permitted. Thanks, Fabio
