On Thu, Oct 14, 2021 at 08:10:00PM +0530, Saurav Girepunje wrote: > Remove goto statement where function simply return value without doing > any cleanup action. > > Simplify the return using goto label to avoid unneeded 'if' condition > check. > > Remove the unneeded and redundant check of variable on goto. > > Remove the assignment of NULL on local variable. You are saying _what_ you are doing here, but not _why_ you are doing this. For example, this last sentance does not make sense, why would you want to do such a thing (hint, I know, but you need to explain it in the changelog...) It's getting better, but the changelog still needs work. Often times that's the hardest part of writing a kernel patch. thanks, greg k-h
