Thus wrote Michael Straube (straube.linux@xxxxxxxxx):
> On 10/5/21 22:08, Martin Kaiser wrote:
> > We set ODM_CMNINFO_INTERFACE to ODM_ITRF_USB as this driver supports
> > only usb. Therefore, dm_odm->SupportInterface is always ODM_ITRF_USB.
> > Simplify some if conditions accordingly. Remove/replace two empty
> > functions.
> > Signed-off-by: Martin Kaiser <martin@xxxxxxxxx>
> > ---
> > drivers/staging/r8188eu/hal/odm_HWConfig.c | 58 +++++++---------------
> > 1 file changed, 19 insertions(+), 39 deletions(-)
> <...>
> > static s32 odm_SignalScaleMapping(struct odm_dm_struct *dm_odm, s32 CurrSig)
> > {
> > - if ((dm_odm->SupportPlatform == ODM_MP) &&
> > - (dm_odm->SupportInterface != ODM_ITRF_PCIE) && /* USB & SDIO */
> > - (dm_odm->PatchID == 10))
> > - return odm_sig_patch_netcore(dm_odm, CurrSig);
> > - else if ((dm_odm->SupportPlatform == ODM_MP) &&
> > - (dm_odm->SupportInterface == ODM_ITRF_PCIE) &&
> > - (dm_odm->PatchID == 19))
> > - return odm_sig_patch_lenove(dm_odm, CurrSig);
> > + if ((dm_odm->SupportPlatform == ODM_MP) && (dm_odm->PatchID == 10))
> > + return 0;
> > else
> > return odm_SignalScaleMapping_92CSeries(dm_odm, CurrSig);
> > }
> dm_odm->SupportPlatform is always ODM_CE, so this could be just:
> return odm_SignalScaleMapping_92CSeries(dm_odm, CurrSig);
> And then it's just an unnecessary wrapper. ;)
I see. I'll send more patches to clean up this area as time permits.
Thanks,
Martin
