Re: [PATCH 5/9] staging: r8188eu: remove two write-only hal components

[Michael Straube <straube.linux@xxxxxxxxx>]

On 10/5/21 22:08, Martin Kaiser wrote:
> RegTxPause and RegBcnCtrlVal from struct hal_data_8188e are set but never
> read. Remove them.
>
> Signed-off-by: Martin Kaiser <martin@xxxxxxxxx>
> ---
>   drivers/staging/r8188eu/hal/usb_halinit.c      | 2 --
>   drivers/staging/r8188eu/include/rtl8188e_hal.h | 3 ---
>   2 files changed, 5 deletions(-)
>
> diff --git a/drivers/staging/r8188eu/hal/usb_halinit.c b/drivers/staging/r8188eu/hal/usb_halinit.c
> index bd3ba6ab364f..1e6885d75bf3 100644
> --- a/drivers/staging/r8188eu/hal/usb_halinit.c
> +++ b/drivers/staging/r8188eu/hal/usb_halinit.c
> @@ -556,8 +556,6 @@ static void _InitBeaconParameters(struct adapter *Adapter)
>   	/*  beacause test chip does not contension before sending beacon. by tynli. 2009.11.03 */
>   	rtw_write16(Adapter, REG_BCNTCFG, 0x660F);
>   
> -	haldata->RegBcnCtrlVal = rtw_read8(Adapter, REG_BCN_CTRL);
> -	haldata->RegTxPause = rtw_read8(Adapter, REG_TXPAUSE);
>   	haldata->RegFwHwTxQCtrl = rtw_read8(Adapter, REG_FWHW_TXQ_CTRL + 2);
>   	haldata->RegReg542 = rtw_read8(Adapter, REG_TBTT_PROHIBIT + 2);
>   	haldata->RegCR_1 = rtw_read8(Adapter, REG_CR + 1);
> diff --git a/drivers/staging/r8188eu/include/rtl8188e_hal.h b/drivers/staging/r8188eu/include/rtl8188e_hal.h
> index bfe32864ded6..b374398bad24 100644
> --- a/drivers/staging/r8188eu/include/rtl8188e_hal.h
> +++ b/drivers/staging/r8188eu/include/rtl8188e_hal.h
> @@ -307,9 +307,6 @@ struct hal_data_8188e {
>   	u8	LastHMEBoxNum;
>   
>   	u8	fw_ractrl;
> -	u8	RegTxPause;
> -	/*  Beacon function related global variable. */
> -	u32	RegBcnCtrlVal;
>   	u8	RegFwHwTxQCtrl;
>   	u8	RegReg542;
>   	u8	RegCR_1;

Looks good to me.

Acked-by: Michael Straube <straube.linux@xxxxxxxxx>

Thanks,
Michael