On Thu, 2021-09-30 at 08:00 +0200, Greg Kroah-Hartman wrote: > On Wed, Sep 29, 2021 at 10:34:46PM +0200, Dawid Esterhuizen wrote: > > This path fixes four checkpatch.pl warnings: > > > > Statements should start on a tabstop [] > > diff --git a/drivers/staging/rtl8712/rtl871x_xmit.h b/drivers/staging/rtl8712/rtl871x_xmit.h [] > > @@ -182,11 +182,11 @@ struct sta_xmit_priv { > > }; > > > > > > struct hw_txqueue { > > - /*volatile*/ sint head; > > - /*volatile*/ sint tail; > > - /*volatile*/ sint free_sz; /*in units of 64 bytes*/ > > - /*volatile*/ sint free_cmdsz; > > - /*volatile*/ sint txsz[8]; > > + /*volatile*/ sint head; > > + /*volatile*/ sint tail; > > + /*volatile*/ sint free_sz; /*in units of 64 bytes*/ > > + /*volatile*/ sint free_cmdsz; > > + /*volatile*/ sint txsz[8]; > > I think you now have added a new checkpatch warning, right? > > This is not the correct indentation anymore, why not work to see if you > can remove the volatile comment instead? And maybe one day do $ sed -i -e 's/\bsint\b/int/' drivers/staging/rtl8712/*.[ch] $ sed -i 19d drivers/staging/rtl8712/basic_types.h