+ dev_fcnt = pdata && pdata->fcnt ? pdata->fcnt : fcnt;
Please use a real if () statement here and do not bury real logic in a
crazy line like this one, as that is all but impossible to maintain over
time.
The same source file already uses the same form of conditional expressions several lines above:
> ret = pdata && pdata->enable ? pdata->enable(pdev) : 0;
> dev->disable_platform = pdata ? pdata->disable : NULL;
Shall I use real if statement for my expression while keeping those as-is? This looks ... strange.
Or shall I convert all conditional expressions to if statements?
Nikita
