On Sunday, September 26, 2021 12:30:14 PM CEST guolongji wrote: > kfree(NULL) is safe and the check 'if (pstat->passoc_req)' before kfree > is not possible. > > Signed-off-by: guolongji <guolongji@xxxxxxxxxxxxx> > --- Why is it "not possible"? Do you get syntax errors? Are the logic and the result of the function altered? If not, control is certainly "possible". Remember that something may be unnecessary and redundant even if it is still possible. Regards, Fabio