On Mon, Sep 20, 2021 at 09:54:41PM +0200, Fabio M. De Francesco wrote: > On Monday, September 20, 2021 9:01:33 PM CEST Dan Carpenter wrote: > > On Mon, Sep 20, 2021 at 06:17:36PM +0200, Fabio M. De Francesco wrote: > > > On Monday, September 20, 2021 3:10:36 PM CEST Dan Carpenter wrote: > > > > Back to the code... uninitialised data is not a problem in the old code, > it's > > > just bad design. The new code cannot affect runtime, it's just better > design. > > > > It would be a problem for KMSan and the kbuild-bot will email you about > > it. From your commit message "Change the type of "data" from __le32 to > > __le16." it's not clear you understand why the kbuild-bot will email you > > and why it's correct to do so. > > I guess that for sure you are right in saying that it is not entirely clear > why the kbuild-bot will email me. However, since the change is correct, but > the commit message is not, I confirm that we'll use your note with only a > slight change (only if you agree): replace KASan with KMSan in your text. > Perfect. Thanks. regards, dan carpenter