On Mon, Sep 20, 2021 at 01:53:37AM +0200, Fabio M. De Francesco wrote: > --- Preface --- > > This is v8 of "shorten and simplify calls chain". The first 14 patches > have already been applied to staging-testing, so we have been requested > to reset the numbering of the remaining patches to 01/19, while discarding > from this new submission the above-mentioned 14 patches (otherwise we would > have submitted a series containing 33 patches). > > The following commit message is provided as it was in v7, both for the > purpose of presenting the whole picture to Maintainers, Reviewers, and to > anybody else who may be interested in knowing the entire design and the > evolution since v1 to the current v8. > > --- Commit message --- > > io_ops abstraction is useless in this driver, since there is only one ops > registration. Without io_ops we can get rid of indirect calls mess and > shorten the calls chain. > > Shorten the calls chain of rtw_read8/16/32() down to the actual reads. > For this purpose unify the three usb_read8/16/32 into the new > usb_read(); make the latter parameterizable with 'size'; embed most of > the code of usbctrl_vendorreq() into usb_read() and use in it the new > usb_control_msg_recv() API of USB Core. > > Shorten the calls chain of rtw_write8/16/32() down to the actual writes. > For this purpose unify the four usb_write8/16/32/N() into the new > usb_write(); make the latter parameterizable with 'size'; embed most of > the code of usbctrl_vendorreq() into usb_write() and use in it the new > usb_control_msg_send() API of USB Core. > > The code with the modifications was thoroughly tested by Pavel Skripkin > using a TP-Link TL-WN722N v2 / v3 [Realtek RTL8188EUS] and by Fabio M. > De Francesco using a ASUSTek Computer, Inc. Realtek 8188EUS [USB-N10 Nano]. > > --- Changelog --- > > v7->v8 (old numbering): > - 1-14: > Patches applied to staging-testing, so they are dropped > from the current v8; > > - 15-19: > Split into 19 patches. Numbering reset to 01. After this > reset, 15-19/19 become 01-19/19 (so we have a total of 33 > patches in this series. Better, still needs a bit more work. I took 2 of these to shorten your load a bit :) thanks, greg k-h
