Re: [PATCH v8 03/19] staging: r8188eu: remove unnecessary test in usbctrl_vendorreq()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: "Fabio M. De Francesco" <fmdefrancesco@xxxxxxxxx>
Subject: Re: [PATCH v8 03/19] staging: r8188eu: remove unnecessary test in usbctrl_vendorreq()
From: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
Date: Mon, 20 Sep 2021 13:47:15 +0200
Cc: Larry Finger <Larry.Finger@xxxxxxxxxxxx>, Phillip Potter <phil@xxxxxxxxxxxxxxxx>, Pavel Skripkin <paskripkin@xxxxxxxxx>, linux-staging@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, David Laight <david.Laight@xxxxxxxxxx>, Dan Carpenter <dan.carpenter@xxxxxxxxxx>, Martin Kaiser <martin@xxxxxxxxx>
In-reply-to: <20210919235356.4151-4-fmdefrancesco@gmail.com>
References: <20210919235356.4151-1-fmdefrancesco@gmail.com> <20210919235356.4151-4-fmdefrancesco@gmail.com>

On Mon, Sep 20, 2021 at 01:53:40AM +0200, Fabio M. De Francesco wrote:
> Remove unnecessary test for "!io_buf" in usbctrl_vendorreq(). Remove the
> no more used "release_mutex:" label.

You need to explain _why_ it is unnecessary.

thanks,

greg k-h

References:
- [PATCH v8 00/19] staging: r8188eu: shorten and simplify calls chains
  - From: Fabio M. De Francesco
- [PATCH v8 03/19] staging: r8188eu: remove unnecessary test in usbctrl_vendorreq()
  - From: Fabio M. De Francesco

Prev by Date: Re: [PATCH v8 01/19] staging: r8188eu: clean up symbols usbctrl_vendorreq()
Next by Date: Re: [PATCH v8 04/19] staging: r8188eu: reorder comments in usbctrl_vendorreq()
Previous by thread: [PATCH v8 03/19] staging: r8188eu: remove unnecessary test in usbctrl_vendorreq()
Next by thread: [PATCH v8 04/19] staging: r8188eu: reorder comments in usbctrl_vendorreq()
Index(es):
- Date
- Thread

[Index of Archives] [Linux Driver Development] [Linux Driver Backports] [DMA Engine] [Linux GPIO] [Linux SPI] [Video for Linux] [Linux USB Devel] [Linux Coverity] [Linux Audio Users] [Linux Kernel] [Linux SCSI] [Yosemite Backpacking]