Re: staging: r8188eu: Can odm_DynamicTxPowerNIC() be removed?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Sep 18, 2021 at 03:31:48PM +0200, Michael Straube wrote:
> Hi Larry, Phillip and all.
> 
> While removing code that checks for the chip type I stumbled upon this:
> 
> 
> void odm_DynamicTxPowerNIC(struct odm_dm_struct *pDM_Odm)
> {
> 	if (!(pDM_Odm->SupportAbility & ODM_BB_DYNAMIC_TXPWR))
> 		return;
> 
> 	if (pDM_Odm->SupportICType == ODM_RTL8188E) {
> 		/*  ??? */
> 		/*  This part need to be redefined. */
> 	}
> }

Always just delete dead code.  The future is very hard to predict so
don't leave things lying around because of possible futures.  Don't be
a hoarder.

regards,
dan carpenter





[Index of Archives]     [Linux Driver Development]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux