Re: [PATCH linux-next] staging: r8188eu: Use kzalloc() instead of kmalloc()+memset()

[Dan Carpenter <dan.carpenter@xxxxxxxxxx>]

On Thu, Sep 16, 2021 at 02:16:58AM +0000, CGEL wrote:
> From: Changcheng Deng <deng.changcheng@xxxxxxxxxx>
> 
> This place can use kzalloc() directly instead of calling kmalloc() then
> memset(). Replace them.
> 
> Reported-by: Zeal Robot <zealci@xxxxxxxxxx>
> Signed-off-by: Changcheng Deng <deng.changcheng@xxxxxxxxxx>
> ---
>  drivers/staging/r8188eu/os_dep/ioctl_linux.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/r8188eu/os_dep/ioctl_linux.c b/drivers/staging/r8188eu/os_dep/ioctl_linux.c
> index 92b8f2c..9c257c4 100644
> --- a/drivers/staging/r8188eu/os_dep/ioctl_linux.c
> +++ b/drivers/staging/r8188eu/os_dep/ioctl_linux.c
> @@ -463,11 +463,10 @@ static int wpa_set_encryption(struct net_device *dev, struct ieee_param *param,
>  		if (wep_key_len > 0) {
>  			wep_key_len = wep_key_len <= 5 ? 5 : 13;
>  			wep_total_len = wep_key_len + FIELD_OFFSET(struct ndis_802_11_wep, KeyMaterial);
> -			pwep = kmalloc(wep_total_len, GFP_KERNEL);
> +			pwep = kzalloc(wep_total_len, GFP_KERNEL);
>  			if (!pwep)
>  				goto exit;

Missing error code as well.  It should be "ret = -ENOMEM;".

regards,
dan carpenter