Re: [PATCH v2 0/4] staging: r8188eu: remove unused fields from struct hal_data_8188e

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 9/15/21 15:34, Fabio M. De Francesco wrote:
On Wednesday, September 15, 2021 11:01:52 AM CEST Michael Straube wrote:
This series removes some unused fields from struct hal_data_8188eu.

Tested on x86_64 with Inter-Tech DMG-02.

v1 -> v2
Fixed a typo in the subject line of patch 3/4.

Michael Straube (4):
   staging: r8188eu: remove unused macros from rtl8188e_hal.h
   staging: r8188eu: remove write-only fields from struct hal_data_8188e
   staging: r8188eu: remove unused enums from rtl8188e_hal.h
   staging: r8188eu: remove unused field from struct hal_data_8188e

  .../staging/r8188eu/hal/rtl8188e_hal_init.c   |  5 -----
  .../staging/r8188eu/include/rtl8188e_hal.h    | 22 -------------------
  2 files changed, 27 deletions(-)

--
2.33.0

Hi Michael,

Due to your removals, this driver is now about a third lighter. After fixing
that little issue that Philip noticed, this series looks as good as any of
yours. So...

Acked-by:  Fabio M. De Francesco <fmdefrancesco@xxxxxxxxx>

Thank you Fabio.

Well others have contributed to rip out unused code too. ;)
It's nice to see so many people care about this driver. Seems there is a
little chance to get it out of staging some day... though there is still
a lot of work/cleanup to do.

Regards,
Michael




[Index of Archives]     [Linux Driver Development]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux