io_ops abstraction is useless in this driver, since there is only one ops
registration. Without io_ops we can get rid of indirect calls mess and
shorten the calls chain.
Shorten the calls chain of rtw_read8/16/32() down to the actual reads.
For this purpose unify the three usb_read8/16/32 into the new
usb_read(); make the latter parameterizable with 'size'; embed most of
the code of usbctrl_vendorreq() into usb_read() and use in it the new
usb_control_msg_recv() API of USB Core.
Shorten the calls chain of rtw_write8/16/32() down to the actual writes.
For this purpose unify the four usb_write8/16/32/N() into the new
usb_write(); make the latter parameterizable with 'size'; embed most of
the code of usbctrl_vendorreq() into usb_write() and use in it the new
usb_control_msg_send() API of USB Core.
The code with the modifications was thoroughly tested by Pavel Skripkin
using a TP-Link TL-WN722N v2 / v3 [Realtek RTL8188EUS] and by Fabio M.
De Francesco using a ASUSTek Computer, Inc. Realtek 8188EUS [USB-N10 Nano].
Fabio M. De Francesco (4):
staging: r8188eu: hal: Clean up usbctrl_vendorreq()
staging: r8188eu: hal: Clean up rtw_read*() and rtw_write*()
staging: r8188eu: Shorten calls chain of rtw_read8/16/32()
staging: r8188eu: Shorten calls chain of rtw_write8/16/32/N()
Pavel Skripkin (14):
staging: r8188eu: remove usb_{read,write}_mem
staging: r8188eu: remove the helpers of rtw_read8()
staging: r8188eu: remove the helpers of rtw_read16()
staging: r8188eu: remove the helpers of rtw_read32()
staging: r8188eu: remove the helpers of usb_write8
staging: r8188eu: remove the helpers of usb_write16
staging: r8188eu: remove the helpers of usb_write32
staging: r8188eu: remove the helpers of usb_writeN
staging: r8188eu: remove the helpers of usb_read_port
staging: r8188eu: remove the helpers of usb_write_port
staging: r8188eu: remove the helpers of usb_read_port_cancel
staging: r8188eu: remove the helpers of usb_write_port_cancel
staging: r8188eu: remove core/rtw_io.c
staging: remove struct _io_ops
drivers/staging/r8188eu/Makefile | 1 -
drivers/staging/r8188eu/core/rtw_io.c | 299 ------------------
drivers/staging/r8188eu/hal/usb_halinit.c | 6 +-
drivers/staging/r8188eu/hal/usb_ops_linux.c | 250 ++++++++-------
drivers/staging/r8188eu/include/rtw_io.h | 89 +-----
drivers/staging/r8188eu/include/usb_ops.h | 2 -
.../staging/r8188eu/include/usb_ops_linux.h | 8 -
drivers/staging/r8188eu/os_dep/usb_intf.c | 8 +-
.../staging/r8188eu/os_dep/usb_ops_linux.c | 20 +-
9 files changed, 157 insertions(+), 526 deletions(-)
delete mode 100644 drivers/staging/r8188eu/core/rtw_io.c
--
2.33.0
