On Tuesday, September 7, 2021 12:10:19 PM CEST David Laight wrote:
> From: Fabio M. De Francesco
> > Sent: 04 September 2021 23:01
> >
> > Shorten the calls chain of rtw_write8/16/32() down to the actual writes.
> > For this purpose unify the four usb_write8/16/32/N() into the new
> > usb_write(); make the latter parameterizable with 'size'; embed most of
> > the code of usbctrl_vendorreq() into usb_write() and use in it the new
> > usb_control_msg_send() API of USB Core.
> >
> ...
> > diff --git a/drivers/staging/r8188eu/hal/usb_ops_linux.c b/drivers/
staging/r8188eu/hal/usb_ops_linux.c
> > index f9c4fd5a2c53..e31d1b1fdb12 100644
> > --- a/drivers/staging/r8188eu/hal/usb_ops_linux.c
> > +++ b/drivers/staging/r8188eu/hal/usb_ops_linux.c
> > @@ -8,76 +8,51 @@
> > #include "../include/recv_osdep.h"
> > #include "../include/rtl8188e_hal.h"
> >
> > -static int usbctrl_vendorreq(struct intf_hdl *pintfhdl, u16 value, void
*pdata, u16 len, u8
> > requesttype)
> > +static int usb_read(struct intf_hdl *intfhdl, u32 addr, void *data, u8
size)
> > {
> > - struct adapter *adapt = pintfhdl->padapter;
> > - struct dvobj_priv *dvobjpriv = adapter_to_dvobj(adapt);
> > + u16 value = (u16)(addr & 0x0000ffff);
> > + struct adapter *adapt = intfhdl->padapter;
> > + struct dvobj_priv *dvobjpriv = adapter_to_dvobj(adapt);
> > struct usb_device *udev = dvobjpriv->pusbdev;
> > - unsigned int pipe;
> > - int status = 0;
> > - u8 *pIo_buf;
> > + int status;
> > + u8 *io_buf;
>
> Some of these changes are whitespace or renames.
> They ought to be in a different patch.
Dear David,
No, they are not.
I guess you were misled by the structure of the patches. There is nothing I
can do about it. Please notice that usb_read() is created in 2/3, and I'm
free to use the name of the variables I like in new functions. Furthermore,
usb_read() is untouched in 3/3. I can see why you thought they are renames :)
>
> I think you'll need 'reverse xmas tree' ordering as well.
>
I didn't know this rule, but I must agree that this style is horrible. I'll
change the order of variables declaration for the purpose of fixing this
ugly "reverse Xmas tree".
Thanks for your review.
Regards,
Fabio
> David
>
> -
> Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1
1PT, UK
> Registration No: 1397386 (Wales)
>
>
