On 08/09/2021 12:57, Cai Huoqing wrote: > Use the devm_platform_ioremap_resource_byname() helper instead of > calling platform_get_resource_byname() and devm_ioremap_resource() > separately > > Signed-off-by: Cai Huoqing <caihuoqing@xxxxxxxxx> > --- > drivers/staging/media/meson/vdec/vdec.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/drivers/staging/media/meson/vdec/vdec.c b/drivers/staging/media/meson/vdec/vdec.c > index e51d69c4729d..8549d95be0f2 100644 > --- a/drivers/staging/media/meson/vdec/vdec.c > +++ b/drivers/staging/media/meson/vdec/vdec.c > @@ -994,7 +994,6 @@ static int vdec_probe(struct platform_device *pdev) > struct device *dev = &pdev->dev; > struct video_device *vdev; > struct amvdec_core *core; > - struct resource *r; > const struct of_device_id *of_id; > int irq; > int ret; > @@ -1006,13 +1005,11 @@ static int vdec_probe(struct platform_device *pdev) > core->dev = dev; > platform_set_drvdata(pdev, core); > > - r = platform_get_resource_byname(pdev, IORESOURCE_MEM, "dos"); > - core->dos_base = devm_ioremap_resource(dev, r); > + core->dos_base = devm_platform_ioremap_resource_byname(pdev, "dos"); > if (IS_ERR(core->dos_base)) > return PTR_ERR(core->dos_base); > > - r = platform_get_resource_byname(pdev, IORESOURCE_MEM, "esparser"); > - core->esparser_base = devm_ioremap_resource(dev, r); > + core->esparser_base = devm_platform_ioremap_resource_byname(pdev, "esparser"); > if (IS_ERR(core->esparser_base)) > return PTR_ERR(core->esparser_base); > > Reviewed-by: Neil Armstrong <narmstrong@xxxxxxxxxxxx>
