Re: [PATCH] Fix formatting for file "hsdma-mt7621.c"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Sep 03, 2021 at 05:49:46PM +0200, Krish Jain wrote:
> On Thu, Sep 2, 2021 at 11:09 AM Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> >
> > On Thu, Sep 02, 2021 at 01:13:39PM +0200, Krish Jain wrote:
> > > This patch fixes the format of the code. It properly formats lines that should not end with a '(' as suggested by checkpath.pl.
> >
> > Please properly line-wrap your changelog text like your editor asked you
> > to.
> >
> > Also, your subject line needs work, look at other commits for this
> > driver with:
> >         git log --oneline drivers/staging/mt7621-dma/
> > and notice how they say the driver name and the subsystem.
> >
> > Please fix up and resend a v2.
> >
> > thanks,
> >
> > greg k-h
> 
> Do you mean I should line-wrap (at 72 columns) the entire thing or
> only that line?

Your whole changelog text needs to be wrapped at 72 columns.

Look at the 'git log' in the kernel tree for hundreds of thousands of
examples :)

thanks,

greg k-h




[Index of Archives]     [Linux Driver Development]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux