On 8/31/21 6:50 AM, Fabio M. De Francesco wrote: > I was wrong in assuming that trivial patches to Greybus are welcome as they > are for other drivers. This is not a correct statement. But as Johan pointed out, even for a trivial patch if you must understand the consequences of what the change does. If testing is not possible, you must work extra hard to ensure your patch is correct. In the first (or an early) version of your patch I pointed out a bug. Later, I suggested the lock might not be necessary and asked you to either confirm it was or explain why it was not, but you didn't do that. I agree that the change appeared trivial, and even sensible, but even trivial patches must result in correct code. And all patches should have good and complete explanations. -Alex
