Hi, On 8/30/21 9:09 AM, Fabio Aiuto wrote: > This patchseries removes a lockdep warning that turned out to > be a false positive. > > All "lockable" queues in the driver are initialized by > a single function. This confuses lockdep which puts all > locks in the same unexistent class. > > Fixed it by doing the initalization of queues in place. > > Done a small code cleaning and removed the no more > used function. > > Tested-on: Lenovo ideapad Miix 300-10IBY Thank you so much for fixing this. The entire series looks good to me: Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx> For the series. Regards, Hans > > Fabio Aiuto (3): > staging: rtl8723bs: unwrap initialization of queues > staging: rtl8723bs: remove unnecessary parentheses > staging: rtl8723bs: remove unused _rtw_init_queue() function > > drivers/staging/rtl8723bs/core/rtw_ap.c | 3 +- > drivers/staging/rtl8723bs/core/rtw_cmd.c | 3 +- > drivers/staging/rtl8723bs/core/rtw_mlme.c | 6 ++-- > drivers/staging/rtl8723bs/core/rtw_recv.c | 12 ++++--- > drivers/staging/rtl8723bs/core/rtw_sta_mgt.c | 15 ++++++--- > drivers/staging/rtl8723bs/core/rtw_xmit.c | 33 ++++++++++++------- > .../staging/rtl8723bs/hal/rtl8723bs_recv.c | 6 ++-- > .../staging/rtl8723bs/os_dep/osdep_service.c | 7 ---- > 8 files changed, 52 insertions(+), 33 deletions(-) >