Re: [PATCH] staging: r8188eu: core: remove null check before vfree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 8/28/21 21:20, Michael Straube wrote:
On 8/28/21 19:54, Saurav Girepunje wrote:
Remove NULL check. NULL check before freeing function is not needed.

Signed-off-by: Saurav Girepunje <saurav.girepunje@xxxxxxxxx>
---
  drivers/staging/r8188eu/core/rtw_sta_mgt.c | 4 +---
  1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/staging/r8188eu/core/rtw_sta_mgt.c b/drivers/staging/r8188eu/core/rtw_sta_mgt.c
index f6dffed53a60..4726771a8403 100644
--- a/drivers/staging/r8188eu/core/rtw_sta_mgt.c
+++ b/drivers/staging/r8188eu/core/rtw_sta_mgt.c
@@ -155,9 +155,7 @@ u32    _rtw_free_sta_priv(struct    sta_priv *pstapriv)
          spin_unlock_bh(&pstapriv->sta_hash_lock);
          /*===============================*/

-        if (pstapriv->pallocated_stainfo_buf)
-            vfree(pstapriv->pallocated_stainfo_buf);
-        }
+        vfree(pstapriv->pallocated_stainfo_buf);

      return _SUCCESS;
  }
--
2.32.0


Acked-by: Michael Straube <straube.linux@xxxxxxxxx>

Thanks,
Michael

Whoops, I missed that you removed the } that belongs to the enclosing if
block. Probably because it is not properly indented in the original
code.

Best regards,
Michael






[Index of Archives]     [Linux Driver Development]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux