Re: [PATCH] staging: r8188eu: core: remove unused function

[Michael Straube <straube.linux@xxxxxxxxx>]

On 8/28/21 17:01, Saurav Girepunje wrote:
> Remove unused function proc_get_adapter_state() from rtw_debug.c file.
>
> Signed-off-by: Saurav Girepunje <saurav.girepunje@xxxxxxxxx>
> ---
>   drivers/staging/r8188eu/core/rtw_debug.c    | 15 ---------------
>   drivers/staging/r8188eu/include/rtw_debug.h |  4 ----
>   2 files changed, 19 deletions(-)
>
> diff --git a/drivers/staging/r8188eu/core/rtw_debug.c b/drivers/staging/r8188eu/core/rtw_debug.c
> index 2ee64cef73f7..c5bb8b05b3c2 100644
> --- a/drivers/staging/r8188eu/core/rtw_debug.c
> +++ b/drivers/staging/r8188eu/core/rtw_debug.c
> @@ -264,21 +264,6 @@ int proc_get_ap_info(char *page, char **start,
>   	return len;
>   }
>
> -int proc_get_adapter_state(char *page, char **start,
> -			  off_t offset, int count,
> -			  int *eof, void *data)
> -{
> -	struct net_device *dev = data;
> -	struct adapter *padapter = (struct adapter *)rtw_netdev_priv(dev);
> -	int len = 0;
> -
> -	len += snprintf(page + len, count - len, "bSurpriseRemoved=%d, bDriverStopped=%d\n",
> -						padapter->bSurpriseRemoved, padapter->bDriverStopped);
> -
> -	*eof = 1;
> -	return len;
> -}
> -
>   int proc_get_trx_info(char *page, char **start,
>   			  off_t offset, int count,
>   			  int *eof, void *data)
> diff --git a/drivers/staging/r8188eu/include/rtw_debug.h b/drivers/staging/r8188eu/include/rtw_debug.h
> index 3c3bf2a4f30e..9de3a0ed12ba 100644
> --- a/drivers/staging/r8188eu/include/rtw_debug.h
> +++ b/drivers/staging/r8188eu/include/rtw_debug.h
> @@ -112,10 +112,6 @@ int proc_get_ap_info(char *page, char **start,
>   		     off_t offset, int count,
>   		     int *eof, void *data);
>
> -int proc_get_adapter_state(char *page, char **start,
> -			   off_t offset, int count,
> -			   int *eof, void *data);
> -
>   int proc_get_trx_info(char *page, char **start,
>   		      off_t offset, int count,
>   		      int *eof, void *data);
> --
> 2.32.0

Looks good to me.

Acked-by: Michael Straube <straube.linux@xxxxxxxxx>


Thanks,
Michael