On Friday, August 27, 2021 4:32:22 PM CEST Pavel Skripkin wrote: > On 8/20/21 1:12 AM, Fabio M. De Francesco wrote: > > Remove _enter_critical_mutex() and _exit_critical_mutex(). They are > > unnecessary wrappers, respectively to mutex_lock_interruptible() and > > to mutex_unlock(). They also have an odd interface that takes an unused > > argument named pirqL of type unsigned long. > > The original code enters the critical section if the mutex API is > > interrupted while waiting to acquire the lock; therefore it could lead > > to a race condition. Use mutex_lock() because it is uninterruptible and > > so avoid that above-mentioned potential race condition. > > > > Signed-off-by: Fabio M. De Francesco <fmdefrancesco@xxxxxxxxx> > > Tested-by: Pavel Skripkin <paskripkin@xxxxxxxxx> > Reviewed-by: Pavel Skripkin <paskripkin@xxxxxxxxx> > > Thanks! > > > With regards, > Pavel Skripkin > Hi Pavel, Thanks very much for testing and reviewing my patch. As you know, Greg wanted it tested but I couldn't do that. I'll add your tags and send a v4 and I guess that now Greg will easily apply. Great help from you, thanks again :) Regards, Fabio
