I unfortunately forgot to add Greg to this thread. Doing so now. I apologize for the confusion, if any. This patch was regarding the staging tree's file android/ashmem.c and declaring the file_operations struct as const as done elsewhere in the kernel, because there are no modifications to its fields. Warm Regards On Fri, Aug 27, 2021 at 8:38 PM Krish Jain <krishjain02939@xxxxxxxxx> wrote: > > So what do you think I can do? > > Best Regards > > > On Fri, Aug 27, 2021 at 10:50 AM Krish Jain <krishjain02939@xxxxxxxxx> wrote: > > > > Hi, yes, this is my first time programming at this low level. And yes, > > I read both docs now. Furthermore the issue is that my current > > hardware can't handle building the kernel, it barely managed to > > survive the first build after 2 hours so I don't know how I can. If I > > change it to static const would it fix the issue and build > > successfully? If not what would be the error message, then I can > > debug. Thanks > > > > On Fri, Aug 27, 2021 at 9:48 AM Fabio M. De Francesco > > <fmdefrancesco@xxxxxxxxx> wrote: > > > > > > On Friday, August 27, 2021 8:49:30 AM CEST Fabio M. De Francesco wrote: > > > > On Friday, August 27, 2021 3:59:28 AM CEST Krish Jain wrote: > > > > > From: Krish Jain <krishjain02939@xxxxxxxxx> > > > > > > > > > > Declare the file_operations struct as const as done elsewhere in the > > > > > kernel, as there are no modifications to its fields. > > > > > > > > > > Signed-off-by: Krish Jain <krishjain02939@xxxxxxxxx> > > > > > --- > > > > > [] > > > > Are you sure that it works? I wouldn't be. > > > > You didn't build this file. Please build your changes before submitting patches. > > > > > > > > Furthermore, please always rebase to the current version of the staging tree. > > > > > > > > Finally, please use the class modifier "static" as the first keyword of a declaration/definition > > > > as it is done everywhere in the kernel (see "grep -rn "static const" drivers/staging/" and > > > > then switch to "const static" and read the output). > > > > > > Please don't misunderstand me: as far as I can see this is your first patch and > > > (I'm pretty sure I can speak for everyone else about this) you are very welcome > > > to staging and to kernel hacking :) > > > > > > However, before posting further works, you'd better read at least the following > > > documents: > > > > > > https://www.kernel.org/doc/html/latest/process/4.Coding.html > > > https://www.kernel.org/doc/html/latest/process/submitting-patches.html > > > > > > And please don't forget to always CC linux-kernel@xxxxxxxxxxxxxxx. > > > > > > Have a nice time with kernel hacking. > > > > > > Thanks, > > > > > > Fabio > > > > > >
