On Fri, Aug 27, 2021 at 04:13:15PM +0000, Bryan Brattlof wrote:
> The sdio_write_mem() function is unused in the driver. We can remove it.
>
> Signed-off-by: Bryan Brattlof <hello@xxxxxxxxxxxxxxxxx>
> ---
> drivers/staging/rtl8723bs/hal/sdio_ops.c | 11 -----------
> drivers/staging/rtl8723bs/include/rtw_io.h | 1 -
> 2 files changed, 12 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/hal/sdio_ops.c b/drivers/staging/rtl8723bs/hal/sdio_ops.c
> index a545832a468e..b784a390c8e1 100644
> --- a/drivers/staging/rtl8723bs/hal/sdio_ops.c
> +++ b/drivers/staging/rtl8723bs/hal/sdio_ops.c
> @@ -356,16 +356,6 @@ static void sdio_read_mem(
> sdio_readN(intfhdl, addr, cnt, rmem);
> }
>
> -static void sdio_write_mem(
> - struct intf_hdl *intfhdl,
> - u32 addr,
> - u32 cnt,
> - u8 *wmem
> -)
> -{
> - sdio_writeN(intfhdl, addr, cnt, wmem);
> -}
> -
> /*
> * Description:
> *Read from RX FIFO
> @@ -474,7 +464,6 @@ void sdio_set_intf_ops(struct adapter *adapter, struct _io_ops *ops)
> ops->_write16 = &sdio_write16;
> ops->_write32 = &sdio_write32;
> ops->_writeN = &sdio_writeN;
> - ops->_write_mem = &sdio_write_mem;
> ops->_write_port = &sdio_write_port;
> }
>
> diff --git a/drivers/staging/rtl8723bs/include/rtw_io.h b/drivers/staging/rtl8723bs/include/rtw_io.h
> index e98083a07a66..87f36b7e880f 100644
> --- a/drivers/staging/rtl8723bs/include/rtw_io.h
> +++ b/drivers/staging/rtl8723bs/include/rtw_io.h
> @@ -91,7 +91,6 @@ struct _io_ops {
> int (*_write32_async)(struct intf_hdl *pintfhdl, u32 addr, u32 val);
>
> void (*_read_mem)(struct intf_hdl *pintfhdl, u32 addr, u32 cnt, u8 *pmem);
> - void (*_write_mem)(struct intf_hdl *pintfhdl, u32 addr, u32 cnt, u8 *pmem);
>
> void (*_sync_irp_protocol_rw)(struct io_queue *pio_q);
>
> --
> 2.30.2
>
>
>
THis changed from the previous version in ways you did not document
anywhere. Please fix up in your v4 notes.
