On Fri, 27 Aug 2021 at 11:08, Fabio M. De Francesco <fmdefrancesco@xxxxxxxxx> wrote: > > Provide a TODO file that lists the tasks that should be carried out in > order to move this driver off drivers/staging. > > Signed-off-by: Fabio M. De Francesco <fmdefrancesco@xxxxxxxxx> > --- > > v2->v3: Added a task suggested by Dan Carpenter > <dan.carpenter@xxxxxxxxxx>. > v1->v2: According to reviews by Fabio Aiuto <fabioaiuto83@xxxxxxxxx> and Greg K-H > <gregkh@xxxxxxxxxxxxxxxxxxx>, remove "[] is currently in development...", > indent and properly wrap the lines, remove the unnecessary last paragraph. > > drivers/staging/r8188eu/TODO | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > create mode 100644 drivers/staging/r8188eu/TODO > > diff --git a/drivers/staging/r8188eu/TODO b/drivers/staging/r8188eu/TODO > new file mode 100644 > index 000000000000..98f918480990 > --- /dev/null > +++ b/drivers/staging/r8188eu/TODO > @@ -0,0 +1,13 @@ > +To-do list: > + > +* Correct the coding style according to Linux guidelines; please read the document > + at https://www.kernel.org/doc/html/latest/process/coding-style.html. > +* Remove unnecessary debugging/printing macros; for those that are still needed > + use the proper kernel API (pr_debug(), dev_dbg(), netdev_dbg()). > +* Remove dead code such as unusued functions, variables, fields, etc.. > +* Use in-kernel API and remove unnecessary wrappers where possible. > +* Fix bugs due to code that sleeps in atomic context. > +* Remove the HAL layer and migrate its functionality into the relevant parts of > + the driver. > +* Switch to use LIB80211. > +* Switch to use MAC80211. > -- > 2.32.0 > Looks good to me. Thanks. Acked-by: Phillip Potter <phil@xxxxxxxxxxxxxxxx> Regards, Phil
