On Fri, Aug 20, 2021 at 12:12:41AM +0200, Fabio M. De Francesco wrote: > Remove _enter_critical_mutex() and _exit_critical_mutex(). They are > unnecessary wrappers, respectively to mutex_lock_interruptible() and > to mutex_unlock(). They also have an odd interface that takes an unused > argument named pirqL of type unsigned long. > The original code enters the critical section if the mutex API is > interrupted while waiting to acquire the lock; therefore it could lead > to a race condition. Use mutex_lock() because it is uninterruptible and > so avoid that above-mentioned potential race condition. > > Signed-off-by: Fabio M. De Francesco <fmdefrancesco@xxxxxxxxx> > --- You have changed the behavior of the code here, how have you tested that this still works properly? thanks, greg k-h
