Re: [PATCH] staging: r8188eu: make rtw_deinit_intf_priv return void

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Thus wrote Pavel Skripkin (paskripkin@xxxxxxxxx):

> rtw_deinit_intf_priv() always return success, so there is no need in
> return value

> Signed-off-by: Pavel Skripkin <paskripkin@xxxxxxxxx>
> ---
>  drivers/staging/r8188eu/os_dep/usb_intf.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)

> diff --git a/drivers/staging/r8188eu/os_dep/usb_intf.c b/drivers/staging/r8188eu/os_dep/usb_intf.c
> index e002070f7fba..37694aa96d13 100644
> --- a/drivers/staging/r8188eu/os_dep/usb_intf.c
> +++ b/drivers/staging/r8188eu/os_dep/usb_intf.c
> @@ -129,13 +129,10 @@ static u8 rtw_init_intf_priv(struct dvobj_priv *dvobj)
>  	return rst;
>  }

> -static u8 rtw_deinit_intf_priv(struct dvobj_priv *dvobj)
> +static void rtw_deinit_intf_priv(struct dvobj_priv *dvobj)
>  {
> -	u8 rst = _SUCCESS;
> -
>  	kfree(dvobj->usb_alloc_vendor_req_buf);
>  	_rtw_mutex_free(&dvobj->usb_vendor_req_mutex);
> -	return rst;
>  }

>  static struct dvobj_priv *usb_dvobj_init(struct usb_interface *usb_intf)
> -- 
> 2.32.0

Acked-by: Martin Kaiser <martin@xxxxxxxxx>




[Index of Archives]     [Linux Driver Development]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux