Thus wrote Phillip Potter (phil@xxxxxxxxxxxxxxxx):
> On Sat, 21 Aug 2021 at 17:49, Martin Kaiser <martin@xxxxxxxxx> wrote:
> > name is a const char * by default. This type should be ok for r8188eu.
> > Signed-off-by: Martin Kaiser <martin@xxxxxxxxx>
> > ---
> > drivers/staging/r8188eu/os_dep/usb_intf.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> > diff --git a/drivers/staging/r8188eu/os_dep/usb_intf.c b/drivers/staging/r8188eu/os_dep/usb_intf.c
> > index e002070f7fba..72556ac10d7d 100644
> > --- a/drivers/staging/r8188eu/os_dep/usb_intf.c
> > +++ b/drivers/staging/r8188eu/os_dep/usb_intf.c
> > @@ -61,7 +61,7 @@ struct rtw_usb_drv {
> > };
> > static struct rtw_usb_drv rtl8188e_usb_drv = {
> > - .usbdrv.name = (char *)"r8188eu",
> > + .usbdrv.name = "r8188eu",
> > .usbdrv.probe = rtw_drv_init,
> > .usbdrv.disconnect = rtw_dev_remove,
> > .usbdrv.id_table = rtw_usb_id_tbl,
> > --
> > 2.20.1
Hi Phil,
> Looks ok to me, thanks. I would consider using a cover letter style
> [PATCH 00/10] style approach as an addition in future though, just my
> personal opinion.
> Acked-by: Phillip Potter <phil@xxxxxxxxxxxxxxxx>
Thanks.
This series is a mixed bag of things I found while poking around in the
code. So I didn't think there was anything useful to say in a cover
letter. Still, I see your point, it makes sense for a patch series to
have a cover letter, I'll add one for future patch series.
Best regards,
Martin
