On Sun, 22 Aug 2021 at 12:06, Fabio M. De Francesco <fmdefrancesco@xxxxxxxxx> wrote: > > On Sunday, August 22, 2021 1:58:10 AM CEST Phillip Potter wrote: > > On Sat, 21 Aug 2021 at 21:23, Saurav Girepunje > > > > <saurav.girepunje@xxxxxxxxx> wrote: > > > Remove the condition with no effect (if == else) in rtw_led.c > > > file. > > > > > > Signed-off-by: Saurav Girepunje <saurav.girepunje@xxxxxxxxx> > > > --- > > > > > > drivers/staging/r8188eu/core/rtw_led.c | 5 +---- > > > 1 file changed, 1 insertion(+), 4 deletions(-) > > > > Thanks for this, looks good. > > > > Acked-by: Phillip Potter <phil@xxxxxxxxxxxxxxxx> > > > > Regards, > > Phil > > Dear Philip, > > Before acking, please check at least if it applies to the current version of > the tree and check if it compiles without adding warnings and / or errors. :-) > > Thanks, > > Fabio > > > > Dear Fabio, An Acked-by merely signals acknowledgement of the patch, and that is looks OK to the person offering the tag. Please see the following quote from the kernel.org documentation: "Acked-by: is not as formal as Signed-off-by:. It is a record that the acker has at least reviewed the patch and has indicated acceptance." It is not, to my knowledge, a commitment from the reviewer that the patch applies to the given tree at that precise moment in time. I reviewed the patch, and indicated my acceptance - the content of the patch is fine. Whilst I will often make an effort to merge + build test many patches, I will not do this with all of them, I simply don't have the time due to other commitments. You can be assured that if I have offered this tag I have at least read the patch and it looks correct to me. Particularly with a driver as in flux as this one, there are going to be many merge conflicts. Advice such as this to me is not particularly helpful, as I can promise you I'm trying :-) Regards, Phil
