On Sun, Aug 22, 2021 at 01:06:09PM +0200, Fabio M. De Francesco wrote: > On Sunday, August 22, 2021 1:58:10 AM CEST Phillip Potter wrote: > > On Sat, 21 Aug 2021 at 21:23, Saurav Girepunje > > > > <saurav.girepunje@xxxxxxxxx> wrote: > > > Remove the condition with no effect (if == else) in rtw_led.c > > > file. > > > > > > Signed-off-by: Saurav Girepunje <saurav.girepunje@xxxxxxxxx> > > > --- > > > > > > drivers/staging/r8188eu/core/rtw_led.c | 5 +---- > > > 1 file changed, 1 insertion(+), 4 deletions(-) > > > > Thanks for this, looks good. > > > > Acked-by: Phillip Potter <phil@xxxxxxxxxxxxxxxx> > > > > Regards, > > Phil > > Dear Philip, > > Before acking, please check at least if it applies to the current version of > the tree and check if it compiles without adding warnings and / or errors. :-) That is not necessary or needed here, I can do that when I apply the patch. greg k-h