On Sat, 21 Aug 2021 at 15:45, Larry Finger <Larry.Finger@xxxxxxxxxxxx> wrote: > > On 8/20/21 7:05 PM, Phillip Potter wrote: > > Remove forward declaration of Efuse_Read1ByteFromFakeContent function > > from core/rtw_efuse.c, as the function is defined in full directly > > after this and therefore this forward declaration is redundant. > > > > Signed-off-by: Phillip Potter <phil@xxxxxxxxxxxxxxxx> > > --- > > drivers/staging/r8188eu/core/rtw_efuse.c | 6 ------ > > 1 file changed, 6 deletions(-) > > > > diff --git a/drivers/staging/r8188eu/core/rtw_efuse.c b/drivers/staging/r8188eu/core/rtw_efuse.c > > index decccf7622f0..45b757ab64e1 100644 > > --- a/drivers/staging/r8188eu/core/rtw_efuse.c > > +++ b/drivers/staging/r8188eu/core/rtw_efuse.c > > @@ -29,12 +29,6 @@ u8 fakeBTEfuseModifiedMap[EFUSE_BT_MAX_MAP_LEN] = {0}; > > #define REG_EFUSE_CTRL 0x0030 > > #define EFUSE_CTRL REG_EFUSE_CTRL /* E-Fuse Control. */ > > /* */ > > - > > -bool > > -Efuse_Read1ByteFromFakeContent( > > - struct adapter *pAdapter, > > - u16 Offset, > > - u8 *Value); > > bool > > Efuse_Read1ByteFromFakeContent( > > struct adapter *pAdapter, > > > > Phil, > > There a number of such forward references immediately followed by the actual > routine. I removed some of these when the driver was in the GitHub repo, but I > missed a few. > > Acked-by: Larry Finger <Larry.Finger@xxxxxxxxxxxx> > > Larry > Dear Larry, Thanks for this, I ended up doing a V2 that declares the function as static as well. No doubt there will be others like this - I just picked this one off as I happened to notice it :-) Regards, Phil