On 21/08/20 04:44PM, Larry Finger wrote:
> This patch is wrong. All the documentation I could find tells me that the
> multi-byte entries in dhcph are big-endian, thus the new line should read:
>
> u32 cookie = be32_to_cpu(dhcph->cookie);
> combined with:
>
> @@ -649,7 +650,7 @@ struct dhcpMessage {
> u_int8_t chaddr[16];
> u_int8_t sname[64];
> u_int8_t file[128];
> - u_int32_t cookie;
> + __be32 cookie;
> u_int8_t options[308]; /* 312 - cookie */
> };
>
> The old code was, in fact, correct, but not in a way that satisfied Sparse.
>
> Larry
Thanks for the review Larry. I understand now, will rework and send it
through
Thanks,
Aakash Hemadri
