On Sat, 2021-08-21 at 10:30 +0200, Michael Straube wrote: > > > On 8/21/21 5:17 AM, Fabio M. De Francesco wrote: > > On Saturday, August 21, 2021 2:05:08 AM CEST Phillip Potter wrote: > > > Remove forward declaration of Efuse_Read1ByteFromFakeContent > > > function > > > from core/rtw_efuse.c, as the function is defined in full > > > directly > > > after this and therefore this forward declaration is redundant. > > > > > > Signed-off-by: Phillip Potter <phil@xxxxxxxxxxxxxxxx> > > > --- > > > drivers/staging/r8188eu/core/rtw_efuse.c | 6 ------ > > > 1 file changed, 6 deletions(-) > > > > Philip, > > > > It's pretty clear that this function has only a translation unit > > visibility. > > Why don't you make it clear by defining it with storage class > > "static"? > > > > Thanks, > > > > Fabio > > > > > > Hi Phillip, > > I agree with Fabio, making the function static avoids the > [-Wmissing-prototypes] warning and makes it clear that it is only > used > in this file. > > Thanks, > > Michael Dear Michael and Fabio, You're both absolutely right, thank you for the feedback. It did occur to me at the time that I could just make this static, and indeed the change introduces a kernel test robot warning as it is currently, due to -Wmissing-prototypes as mentioned. I shall rework, many thanks. Regards, Phil
