Re: [PATCH] staging: r8188eu: Add spaces before and after logical '&'

[Michael Straube <straube.linux@xxxxxxxxx>]

On 8/17/21 4:26 AM, Abhishek Anand Kulkarni wrote:
> Fix Checkpatch.pl warning to add space before and after logical '&'
> operator
>
> Signed-off-by: Abhishek Anand Kulkarni <kulkaraniabhishekanand@xxxxxxxxx>
> ---
>   drivers/staging/r8188eu/core/rtw_ioctl_set.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/r8188eu/core/rtw_ioctl_set.c b/drivers/staging/r8188eu/core/rtw_ioctl_set.c
> index a7f966a..570f25f 100644
> --- a/drivers/staging/r8188eu/core/rtw_ioctl_set.c
> +++ b/drivers/staging/r8188eu/core/rtw_ioctl_set.c
> @@ -630,7 +630,7 @@ u8 rtw_set_802_11_add_key(struct adapter *padapter, struct ndis_802_11_key *key)
>   		struct ndis_802_11_wep *wep = &padapter->securitypriv.ndiswep;
>   
>   		wep->Length = len;
> -		keyindex = key->KeyIndex&0x7fffffff;
> +		keyindex = key->KeyIndex & 0x7fffffff;
>   		wep->KeyIndex = keyindex ;
>   		wep->KeyLength = key->KeyLength;
>   

Hi Abhishek,

there is already a pending patch that addresses this.

https://lore.kernel.org/linux-staging/20210816155818.24005-9-straube.linux@xxxxxxxxx/T/#u

Regards,
Michael