On Mon, Aug 16, 2021 at 09:46:08AM -0500, Alex Elder wrote: > On 8/14/21 1:11 PM, Fabio M. De Francesco wrote: > > Convert greybus/uart.c from IDR to XArray. The abstract data type XArray > > is more memory-efficient, parallelisable, and cache friendly. It takes > > advantage of RCU to perform lookups without locking. Furthermore, IDR is > > deprecated because XArray has a better (cleaner and more consistent) API. > > I haven't verified the use of the new API (yet) but I have a few > comments on your patch, below. > > -Alex > > > Reported-by: kernel test robot <lkp@xxxxxxxxx> > > Signed-off-by: Fabio M. De Francesco <fmdefrancesco@xxxxxxxxx> > > I'm not sure I'm right about this... But the actual change you're > making has nothing to do with what the Intel test robot reported. > I personally find the "Reported-by" here a little misleading, but > maybe the "Link" line that gets added will provide explanation. > > Anyway, unless someone else contradicts/corrects me, I'd rather > not have the "Reported-by" here (despite wanting to provide much > credit to <lkp@xxxxxxxxx>...). You are correct, "Reported-by:" does not make sense here. thanks, greg k-h