Hi Dan and Phil, Thus wrote Dan Carpenter (dan.carpenter@xxxxxxxxxx): > Please think of the subject and the commit message as two different > things. Often it's people reviewing on email will only read one or the > other. In other words just restate the subject: ok, I'll keep that in mind for further patches. > > Dear Martin, > > Just my personal opinion, but I'd be inclined to strip out all DBG_88E > > calls totally. If there are necessary functions being called such as > > device_may_wakeup() we can always just keep this part and remove the > > macro call (not checked this function out myself yet). Thanks. I'd agree with you, Phil. Most DBG_88E prints don't say anything useful. This comment from Greg made me drop the DBG_88E removal for now https://lore.kernel.org/linux-staging/20210803201511.29000-1-martin@xxxxxxxxx/T/#m05d82a0ca8ed36180ebdc987114b4d892445c52d A compromise would be to remove only those DBG_88E prints which are really not helpful. Best regards, Martin
