On Wed, 11 Aug 2021 at 21:15, Martin Kaiser <martin@xxxxxxxxx> wrote: > > It seems that for now, we can only build this driver as a module. > > Use the same mechanism as other drivers (such as rtl8723bs or the > deprecated rtl8188eu) to enforce building as a module, i.e. depend on m > in Kconfig instead of setting CONFIG_R8188EU = m in the Makefile. > > If we set CONFIG_R8188EU in the Makefile, this setting will not be visible > in .config. > > Signed-off-by: Martin Kaiser <martin@xxxxxxxxx> > --- > drivers/staging/r8188eu/Kconfig | 1 + > drivers/staging/r8188eu/Makefile | 2 -- > 2 files changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/staging/r8188eu/Kconfig b/drivers/staging/r8188eu/Kconfig > index 6323d63a4a1b..dc1719d3f2e4 100644 > --- a/drivers/staging/r8188eu/Kconfig > +++ b/drivers/staging/r8188eu/Kconfig > @@ -2,6 +2,7 @@ > config R8188EU > tristate "Realtek RTL8188EU Wireless LAN NIC driver" > depends on WLAN && USB && CFG80211 > + depends on m > select WIRELESS_EXT > select WEXT_PRIV > select LIB80211 > diff --git a/drivers/staging/r8188eu/Makefile b/drivers/staging/r8188eu/Makefile > index 7f6658f931d1..cca7a58c5f29 100644 > --- a/drivers/staging/r8188eu/Makefile > +++ b/drivers/staging/r8188eu/Makefile > @@ -4,8 +4,6 @@ EXTRA_CFLAGS += -O1 > > ccflags-y += -D__CHECK_ENDIAN__ > > -CONFIG_R8188EU = m > - > CONFIG_USB_HCI = y > > CONFIG_BT_COEXIST = n > -- > 2.20.1 > Dear Martin, Looks good. Acked-by: Phillip Potter <phil@xxxxxxxxxxxxxxxx> Regards, Phil
